Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Qc autoload project #294

Closed local-minimum closed 6 years ago

local-minimum commented 6 years ago

Introduces a link on the ScanningJobPanel to QC the project's analysis. This makes the QC UI autoload it hiding the project selector. If there is no analysis for the project yet, an error message is displayed.

Fixes a few things with Luciano's code because they were making it annoying debugging the current implementation.

Will not fix css lint issues as these lines shouldn't have been included in the PR to start, but editor made some trailing spaces and such changes when I thought it was making a simpler solution than the current solution.

codecov-io commented 6 years ago

Codecov Report

Merging #294 into master will increase coverage by 0.66%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   45.39%   46.05%   +0.66%     
==========================================
  Files         194      195       +1     
  Lines       19127    19356     +229     
  Branches     2972     2999      +27     
==========================================
+ Hits         8682     8914     +232     
  Misses       9998     9998              
+ Partials      447      444       -3
Impacted Files Coverage Δ
...server_data/js/src/components/ScanningJobPanel.jsx 100% <ø> (ø) :arrow_up:
scanomatic/ui_server_data/js/specs/qc2.spec.js 100% <100%> (ø)
...data/js/specs/components/ScanningJobPanel.spec.jsx 100% <100%> (ø) :arrow_up:
scanomatic/ui_server/scans_api.py 96.29% <0%> (-0.38%) :arrow_down:
scanomatic/util/generic_name.py 100% <0%> (ø) :arrow_up:
scanomatic/ui_server/scan_jobs_api.py 92.63% <0%> (+0.32%) :arrow_up:
scanomatic/ui_server/scanners_api.py 98.83% <0%> (+0.5%) :arrow_up:
scanomatic/data_processing/phases/segmentation.py 74.58% <0%> (+0.55%) :arrow_up:
scanomatic/image_analysis/grid.py 76.6% <0%> (+0.75%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8218976...1fe64e8. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.3%) to 42.322% when pulling 1fe64e804f70286a75611ff643b19e8f21d7bc7a on qc-autoload-project into 8218976515ae0f71e1e16391e6e25b04099e3dc0 on master.