search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Make better use of the docker cache when building the ui #305

Closed gdetrez closed 6 years ago

gdetrez commented 6 years ago

installing package is expensive: make sure we only do it when necessary.

codecov-io commented 6 years ago

Codecov Report

Merging #305 into master will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   37.79%   37.81%   +0.02%     
==========================================
  Files         168      168              
  Lines       16391    16391              
  Branches     2908     2908              
==========================================
+ Hits         6195     6199       +4     
+ Misses       9771     9769       -2     
+ Partials      425      423       -2
Impacted Files Coverage Δ
scanomatic/data_processing/phases/segmentation.py 73.74% <0%> (+1.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fcfc6ab...afaba19. Read the comment docs.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 43.034% when pulling afaba1921a66b1fed2feea465a6df7cb08696969 on gdetrez:docker-npm-cache into fcfc6abff25eb32210d73b1aee96538d2552af9a on Scan-o-Matic:master.