Closed gdetrez closed 6 years ago
Merging #324 into master will increase coverage by
0.67%
. The diff coverage is98.26%
.
@@ Coverage Diff @@
## master #324 +/- ##
=========================================
+ Coverage 36.52% 37.2% +0.67%
=========================================
Files 165 167 +2
Lines 16421 16590 +169
Branches 2890 2922 +32
=========================================
+ Hits 5998 6172 +174
+ Misses 10003 9999 -4
+ Partials 420 419 -1
Impacted Files | Coverage Δ | |
---|---|---|
...ersions/f9a3e426a0ce_create_calibrations_tables.py | 93.75% <93.75%> (ø) |
|
scanomatic/data/calibrationstore.py | 98.98% <98.98%> (ø) |
|
...server_data/js/src/components/ScanningJobPanel.jsx | 100% <0%> (ø) |
:arrow_up: |
.../ui_server_data/js/src/components/ScanningRoot.jsx | 100% <0%> (ø) |
:arrow_up: |
scanomatic/data_processing/phases/segmentation.py | 74.93% <0%> (+1.11%) |
:arrow_up: |
...r_data/js/src/containers/ScanningRootContainer.jsx | 100% <0%> (+10%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5fc9f60...348f38a. Read the comment docs.
Add migration script to create the tables,
CalibrationStore
and integration tests.I didn't change the data model itself: the information stored in the database is the same as what was in the
.ccc
files and with approximately the same structure.The default calibration is added to the database directly as part of the migration. This makes the code simpler (no special cases) but the tests have to take it into account.