search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Bug fix in NewScanningJobContainer #335

Closed gdetrez closed 6 years ago

gdetrez commented 6 years ago

The React lifecycle method called when props are updated is named componentWillReceiveProps, not willRecieveNewProps.

codecov-io commented 6 years ago

Codecov Report

Merging #335 into master will decrease coverage by 3.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #335     +/-   ##
=========================================
- Coverage   37.57%   34.47%   -3.1%     
=========================================
  Files         172      135     -37     
  Lines       16430    15494    -936     
  Branches     2890     2786    -104     
=========================================
- Hits         6173     5342    -831     
+ Misses       9848     9751     -97     
+ Partials      409      401      -8
Impacted Files Coverage Δ
scanomatic/data_processing/phases/analysis.py 69.79% <0%> (-3.13%) :arrow_down:
...i_server_data/js/src/containers/PlateContainer.jsx
.../ui_server_data/js/src/components/ColonyEditor.jsx
scanomatic/ui_server_data/js/src/api.js
...matic/ui_server_data/js/src/components/CCCRoot.jsx
...nomatic/ui_server_data/js/src/components/Plate.jsx
...atic/ui_server_data/js/src/components/Gridding.jsx
scanomatic/ui_server_data/js/src/prop-types.js
...c/ui_server_data/js/src/components/ImageUpload.jsx
...a/js/src/containers/CCCInitializationContainer.jsx
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79353dd...1e53921. Read the comment docs.