Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Delete UI integration #336

Closed gdetrez closed 6 years ago

gdetrez commented 6 years ago

Integrate the changes from the previous PRs: #331, #333, and #335

Refactor <ScanningJobPanel/> to handle the job removing interaction:

Add system tests for removing scanning jobs.

Note: I had to make the panel larger to accomodate the remove dialogue as provided in the UI mocks.

Screenshots:

step 1 image

step 2 image

Started jobs have no Remove button image

codecov-io commented 6 years ago

Codecov Report

Merging #336 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   37.65%   37.73%   +0.08%     
==========================================
  Files         174      176       +2     
  Lines       16446    16467      +21     
  Branches     2890     2893       +3     
==========================================
+ Hits         6192     6214      +22     
  Misses       9846     9846              
+ Partials      408      407       -1
Impacted Files Coverage Δ
...r_data/js/src/containers/ScanningRootContainer.jsx 100% <ø> (ø) :arrow_up:
.../ui_server_data/js/src/components/ScanningRoot.jsx 100% <ø> (ø) :arrow_up:
...server_data/js/src/components/ScanningJobPanel.jsx 100% <100%> (ø) :arrow_up:
...er_data/js/src/components/ScanningJobPanelBody.jsx 100% <100%> (ø)
..._data/js/src/components/ScanningJobStatusLabel.jsx 100% <100%> (ø)
scanomatic/data_processing/phases/segmentation.py 74.09% <0%> (+0.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91314f2...90c8483. Read the comment docs.

local-minimum commented 6 years ago

I don't see the ScanningJobRemoveDialogue implementation in here.

gdetrez commented 6 years ago

I don't see the ScanningJobRemoveDialogue implementation in here.

:arrow_right: #333