Closed local-minimum closed 6 years ago
Merging #343 into master will increase coverage by
1.49%
. The diff coverage is33.33%
.
@@ Coverage Diff @@
## master #343 +/- ##
=========================================
+ Coverage 37.91% 39.4% +1.49%
=========================================
Files 179 179
Lines 16458 16443 -15
Branches 2889 2889
=========================================
+ Hits 6240 6480 +240
+ Misses 9813 9539 -274
- Partials 405 424 +19
Impacted Files | Coverage Δ | |
---|---|---|
scanomatic/io/paths.py | 69.67% <ø> (-2.84%) |
:arrow_down: |
scanomatic/ui_server/general.py | 22.41% <0%> (ø) |
:arrow_up: |
scanomatic/ui_server/ui_server.py | 39.39% <0%> (+39.39%) |
:arrow_up: |
scanomatic/ui_server/ui_pages.py | 58.53% <37.5%> (+1.03%) |
:arrow_up: |
scanomatic/data_processing/phenotyper.py | 27.51% <0%> (ø) |
:arrow_up: |
scanomatic/qc/phenotype_results.py | 0% <0%> (ø) |
:arrow_up: |
scanomatic/data_processing/phases/features.py | 17.23% <0%> (ø) |
:arrow_up: |
scanomatic/data_processing/phases/segmentation.py | 74.65% <0%> (+0.55%) |
:arrow_up: |
scanomatic/ui_server/qc_api.py | 5.36% <0%> (+5.36%) |
:arrow_up: |
... and 12 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b30c5df...16b915a. Read the comment docs.
Don't want to fix stickler errors because they are mostly not due to my changes and those that are would have quite a few consequences if they are to be fixed.
It was called Map
before but that caused conflicts with some of our external js-libs on some of the views. I'm not sure it can be reverted.
It was called Map before but that caused conflicts with some of our external js-libs on some of the views. I'm not sure it can be reverted.
Oh, I see. I didn't see it in the other file, sorry. What about browser support for template literals?
?ver={{ version }}
helper.js
since it collided with other function somewhere.