Closed gdetrez closed 6 years ago
LGTM, but no point accepting until tests pass because it will dismiss my review....
Merging #345 into master will decrease coverage by
0.05%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 39.4% 39.35% -0.06%
==========================================
Files 179 179
Lines 16443 16444 +1
Branches 2889 2889
==========================================
- Hits 6480 6471 -9
- Misses 9560 9566 +6
- Partials 403 407 +4
Impacted Files | Coverage Δ | |
---|---|---|
scanomatic/ui_server/ui_pages.py | 57.14% <66.66%> (-1.4%) |
:arrow_down: |
scanomatic/data_processing/phases/analysis.py | 69.79% <0%> (-3.13%) |
:arrow_down: |
scanomatic/data_processing/phases/segmentation.py | 72.98% <0%> (-1.68%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b65815c...76e1c07. Read the comment docs.
Add a new path
/projects
with a web page rendering a simple react component and a system test ensuring that everything works.I also updated the babel config to enable object spread (i.e.
{ ...object }
).