search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Update <NewProjectPanel/> to show errors per field #353

Closed gdetrez closed 6 years ago

gdetrez commented 6 years ago

The component now expects a Map of errors, and it renders like this:

image

codecov-io commented 6 years ago

Codecov Report

Merging #353 into master will increase coverage by <.01%. The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #353      +/-   ##
=========================================
+ Coverage   49.69%   49.7%   +<.01%     
=========================================
  Files         229     229              
  Lines       19821   19826       +5     
  Branches     2891    2894       +3     
=========================================
+ Hits         9851    9855       +4     
+ Misses       9564    9563       -1     
- Partials      406     408       +2
Impacted Files Coverage Δ
.../ui_server_data/js/src/components/ProjectsRoot.jsx 100% <100%> (ø) :arrow_up:
..._server_data/js/src/components/NewProjectPanel.jsx 66.66% <33.33%> (-19.05%) :arrow_down:
scanomatic/image_analysis/grid.py 75.93% <0%> (-0.76%) :arrow_down:
scanomatic/data_processing/phases/segmentation.py 74.37% <0%> (+1.11%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ffb7581...4792f22. Read the comment docs.