search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Make jasmine fail on console.error #369

Closed gdetrez closed 6 years ago

gdetrez commented 6 years ago

This adds a spy on console.error that throw an exception. This mostly concerns prop types. That way, there's no need to scroll through the test results to look for error message (that don't even appear under the correct test). Instead, the test will fail.

Fix the existing errors.

codecov-io commented 6 years ago

Codecov Report

Merging #369 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   40.26%   40.26%   +<.01%     
==========================================
  Files         195      195              
  Lines       16716    16718       +2     
  Branches     2921     2921              
==========================================
+ Hits         6730     6731       +1     
- Misses       9571     9573       +2     
+ Partials      415      414       -1
Impacted Files Coverage Δ
.../ui_server_data/js/src/components/ProjectsRoot.jsx 100% <100%> (ø) :arrow_up:
scanomatic/data_processing/phases/segmentation.py 74.37% <0%> (-0.28%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3191383...b27f88e. Read the comment docs.