Closed gdetrez closed 6 years ago
Merging #372 into master will increase coverage by
0.03%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 40.29% 40.32% +0.03%
==========================================
Files 195 196 +1
Lines 16729 16735 +6
Branches 2917 2918 +1
==========================================
+ Hits 6741 6749 +8
Misses 9573 9573
+ Partials 415 413 -2
Impacted Files | Coverage Δ | |
---|---|---|
...omatic/ui_server_data/js/src/projects/selectors.js | 95.55% <ø> (ø) |
:arrow_up: |
.../ui_server_data/js/src/components/ProjectPanel.jsx | 100% <100%> (+33.33%) |
:arrow_up: |
...data/js/src/projects/reducers/entities/scanners.js | 100% <100%> (ø) |
|
.../ui_server_data/js/src/components/ProjectsRoot.jsx | 100% <100%> (ø) |
:arrow_up: |
scanomatic/data_processing/phases/segmentation.py | 73.81% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5af537a...deecaa5. Read the comment docs.
This connects all the new components to the state:
newExperiment*
props in the appropriate components<ExperimentPanel/>
s for each projects' experiment.Refactor
<ProjectPanel/>
: instead of rendering the (new) experiment in the<ProjectPanel/>
componenet, they are passed as children. This makes the component much simpler and avoid passing a gazillion props through.