Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Pinning inputs and displays #385

Closed local-minimum closed 6 years ago

local-minimum commented 6 years ago

Only showing details of the form and the info-table.

New experiment

screenshot from 2018-05-08 18-27-50

Errors

screenshot from 2018-05-08 18-28-09

Listing experiments

This doesn't match the input above, here plate 3 is left empty, all other plates have stuff screenshot from 2018-05-08 18-27-28

codecov-io commented 6 years ago

Codecov Report

Merging #385 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   40.84%   40.85%   +0.01%     
==========================================
  Files         199      199              
  Lines       16885    16881       -4     
  Branches     2949     2946       -3     
==========================================
+ Hits         6896     6897       +1     
+ Misses       9576     9551      -25     
- Partials      413      433      +20
Impacted Files Coverage Δ
...omatic/ui_server_data/js/src/projects/selectors.js 95.55% <ø> (ø) :arrow_up:
...a/js/src/projects/reducers/entities/experiments.js 100% <ø> (ø) :arrow_up:
...tic/ui_server_data/js/src/projects/StateBuilder.js 97.26% <ø> (ø) :arrow_up:
scanomatic/ui_server_data/js/src/prop-types.js 100% <ø> (ø) :arrow_up:
...anomatic/ui_server_data/js/src/projects/actions.js 95% <100%> (+11.21%) :arrow_up:
...ui_server_data/js/src/components/PinningInputs.jsx 100% <100%> (ø)
...rver_data/js/src/components/NewExperimentPanel.jsx 100% <100%> (ø) :arrow_up:
...r_data/js/src/components/ExperimentPanel/index.jsx 97.22% <100%> (+0.03%) :arrow_up:
...ta/js/src/projects/reducers/forms/newExperiment.js 91.66% <100%> (+0.75%) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8e90e8...1140e82. Read the comment docs.

local-minimum commented 6 years ago

That should hopefully deal with all occurrences of pinning... they were a few.

gdetrez commented 6 years ago

lgtm