Closed local-minimum closed 5 years ago
This re-implements part of the create fixtures UI without a redux-store. Since that is my next step, I would like to get feedback on these rather complex components (interactions-wise) getting ahead of myself with the store.
Merging #390 into master will increase coverage by
0.63%
. The diff coverage is84.71%
.
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
+ Coverage 41.06% 41.69% +0.63%
==========================================
Files 206 212 +6
Lines 16948 17187 +239
Branches 2953 2990 +37
==========================================
+ Hits 6959 7166 +207
+ Misses 9576 9567 -9
- Partials 413 454 +41
Impacted Files | Coverage Δ | |
---|---|---|
...er_data/js/src/components/FixtureGrayscalePlot.jsx | 25% <25%> (ø) |
|
.../ui_server_data/js/src/components/FixtureImage.jsx | 84.05% <84.05%> (ø) |
|
...ui_server_data/js/src/components/FixtureEditor.jsx | 84.61% <84.61%> (ø) |
|
...c/ui_server_data/js/src/helpers/GlobalEventsSpy.js | 85.71% <85.71%> (ø) |
|
...c/ui_server_data/js/src/helpers/toLookLikeImage.js | 94.11% <94.11%> (ø) |
|
...c/ui_server_data/js/src/components/ImageDetail.jsx | 94.87% <94.87%> (ø) |
|
scanomatic/qc/phenotype_results.py | 0% <0%> (ø) |
:arrow_up: |
...i_server_data/js/src/components/ScannersStatus.jsx | 100% <0%> (ø) |
:arrow_up: |
scanomatic/ui_server/tools_api.py | 8.77% <0%> (ø) |
:arrow_up: |
scanomatic/ui_server/general.py | 22.41% <0%> (ø) |
:arrow_up: |
... and 11 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d4a5129...b9c57f6. Read the comment docs.
I think you should probably walk us through this one live.
I'm just gonna abandon this PR for now. I'll keep the branch should we ever work on it again... or maybe I should just merge it into master because why not?