Closed local-minimum closed 6 years ago
Merging #405 into master will increase coverage by
0.12%
. The diff coverage is92.45%
.
@@ Coverage Diff @@
## master #405 +/- ##
==========================================
+ Coverage 41.51% 41.64% +0.12%
==========================================
Files 215 215
Lines 17085 17122 +37
Branches 2954 2954
==========================================
+ Hits 7093 7130 +37
+ Misses 9576 9558 -18
- Partials 416 434 +18
Impacted Files | Coverage Δ | |
---|---|---|
scanomatic/ui_server_data/js/src/qc/actions.js | 95% <100%> (+1.66%) |
:arrow_up: |
scanomatic/ui_server_data/js/src/qc/selectors.js | 100% <100%> (ø) |
:arrow_up: |
...atic/ui_server_data/js/src/qc/reducers/settings.js | 100% <100%> (ø) |
:arrow_up: |
...nomatic/ui_server_data/js/src/qc/reducers/plate.js | 100% <100%> (ø) |
:arrow_up: |
...canomatic/ui_server_data/js/src/qc/StateBuilder.js | 100% <100%> (ø) |
:arrow_up: |
scanomatic/ui_server_data/js/src/qc/bridge.js | 87.87% <75%> (-7.58%) |
:arrow_down: |
scanomatic/data_processing/phenotyper.py | 27.51% <0%> (ø) |
:arrow_up: |
scanomatic/qc/phenotype_results.py | 0% <0%> (ø) |
:arrow_up: |
scanomatic/ui_server/general.py | 23.48% <0%> (ø) |
:arrow_up: |
scanomatic/ui_server/tools_api.py | 8.77% <0%> (ø) |
:arrow_up: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 47ef60a...6c0dcb7. Read the comment docs.
This moves the control over what position/curve is focused/shown entirely into the redux store. In there it is entirely driven by the selected quality index.
I've mostly relied on the unit-tests of the store and bridge code and the system tests that existed. They cover the vast majority of functionality that is touched by this PR. There are some details like validating which position on the heatmap gets that circle mark at each time as well as the grid images thing. I opted to not extend them for this PR as it is rather huge. I can add them though, but it might be better to add them in their own PR in that case?