Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Qindex input box #409

Closed skymandr closed 6 years ago

skymandr commented 6 years ago

Replaced panel showing current qindex with an input box, and re-purposed the reset-button as a set-button.

Since the "hot keys" for switching plates interfered with using the input in a natural way, I removed those.

qindex_input

codecov-io commented 6 years ago

Codecov Report

Merging #409 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #409   +/-   ##
=======================================
  Coverage   41.62%   41.62%           
=======================================
  Files         215      215           
  Lines       17122    17122           
  Branches     2954     2954           
=======================================
  Hits         7127     7127           
+ Misses       9579     9559   -20     
- Partials      416      436   +20
Impacted Files Coverage Δ
scanomatic/ui_server/general.py 23.48% <0%> (ø) :arrow_up:
scanomatic/qc/phenotype_results.py 0% <0%> (ø) :arrow_up:
scanomatic/ui_server/data_api.py 9.65% <0%> (ø) :arrow_up:
scanomatic/data_processing/phenotyper.py 27.51% <0%> (ø) :arrow_up:
scanomatic/data_processing/phases/features.py 17.23% <0%> (ø) :arrow_up:
scanomatic/ui_server/tools_api.py 8.77% <0%> (ø) :arrow_up:
scanomatic/io/source.py 18.08% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d9755ff...209d581. Read the comment docs.

gdetrez commented 6 years ago

Is the state updated if you use the little arrows ?

skymandr commented 6 years ago

@gdetrez : Is the state updated if you use the little arrows ?

No, it is not. I'm not sure that's possible, since it isn't a react component. I removed them by CSS-magic.