Closed local-minimum closed 6 years ago
local-minimum
commented
6 years ago wow stickler really did a number on the code changing way more than I did.
I started it up and there seems to be no issues with the changes so might as well keep stickler's changes.
codecov-io
commented
6 years ago Merging #414 into master will increase coverage by
0.04%. The diff coverage isn/a.
@@ Coverage Diff @@
## master #414 +/- ##
==========================================
+ Coverage 41.58% 41.63% +0.04%
==========================================
Files 215 215
Lines 17122 17122
Branches 2954 2954
==========================================
+ Hits 7121 7128 +7
+ Misses 9582 9558 -24
- Partials 419 436 +17| Impacted Files | Coverage Δ | |
|---|---|---|
| scanomatic/qc/phenotype_results.py | 0% <0%> (ø) |
:arrow_up: |
| scanomatic/data_processing/phenotyper.py | 27.51% <0%> (ø) |
:arrow_up: |
| scanomatic/ui_server/data_api.py | 9.65% <0%> (ø) |
:arrow_up: |
| scanomatic/data_processing/phases/features.py | 17.23% <0%> (ø) |
:arrow_up: |
| scanomatic/ui_server/general.py | 23.48% <0%> (ø) |
:arrow_up: |
| scanomatic/ui_server/tools_api.py | 8.77% <0%> (ø) |
:arrow_up: |
| scanomatic/io/source.py | 18.08% <0%> (ø) |
:arrow_up: |
| scanomatic/image_analysis/grid.py | 76.69% <0%> (+0.75%) |
:arrow_up: |
| scanomatic/data_processing/phases/segmentation.py | 74.09% <0%> (+1.39%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3592ca6...22b5c80. Read the comment docs.
Note that this contains changes from #413 so that the tests don't fail
There was a bit of a bug before that it wasn't the phenotype but the uri for getting plate specific uris for the phenotype that got passed to the store. This fixes that bug and also updates some names so that they will align with what we'll call them.