search

Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

QC-Marking individual curves [builds upon #412] #416

Closed local-minimum closed 5 years ago

local-minimum commented 6 years ago

This makes it possible to mark positions without waiting for the request to the api to go through. However the pending marked position is locked/dirty until the request goes through.

It contains the changes in #412, so probably process that one first.

codecov-io commented 6 years ago

Codecov Report

Merging #416 into master will increase coverage by 0.33%. The diff coverage is 98.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #416      +/-   ##
==========================================
+ Coverage   41.81%   42.14%   +0.33%     
==========================================
  Files         216      217       +1     
  Lines       17182    17279      +97     
  Branches     2954     2954              
==========================================
+ Hits         7184     7283      +99     
+ Misses       9581     9561      -20     
- Partials      417      435      +18
Impacted Files Coverage Δ
...atic/ui_server_data/js/src/api/getPhenotypeData.js 100% <ø> (ø) :arrow_up:
scanomatic/ui_server_data/js/src/qc/selectors.js 100% <100%> (ø) :arrow_up:
scanomatic/ui_server_data/js/src/api/index.js 83.69% <100%> (+0.36%) :arrow_up:
...canomatic/ui_server_data/js/src/qc/StateBuilder.js 100% <100%> (ø) :arrow_up:
...nomatic/ui_server_data/js/src/qc/reducers/plate.js 100% <100%> (ø) :arrow_up:
...omatic/ui_server_data/js/src/api/setCurveQCMark.js 100% <100%> (ø)
scanomatic/ui_server_data/js/src/qc/actions.js 97.33% <96.29%> (-0.59%) :arrow_down:
scanomatic/ui_server/data_api.py 9.65% <0%> (ø) :arrow_up:
scanomatic/ui_server/tools_api.py 8.77% <0%> (ø) :arrow_up:
scanomatic/data_processing/phenotyper.py 27.51% <0%> (ø) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f2bba4...37a260a. Read the comment docs.

local-minimum commented 5 years ago

The comment sent me down a two days rabbit hole so while I think it is true that it isn't needed I think its better to deal with that some other time.