Scan-o-Matic / scanomatic

Scanomatic
GNU General Public License v3.0
10 stars 4 forks source link

Extending API to be able to request normalized phenotypes [builds on #417] #418

Closed local-minimum closed 5 years ago

local-minimum commented 6 years ago

The updates the actions and the api for requesting phenotypes so that normalized and non-normalized phenotypes can be gotten. It doesn't add normalized phenotypes to the store, but raises an error for the time being.

builds on #417

codecov-io commented 6 years ago

Codecov Report

Merging #418 into master will increase coverage by 0.51%. The diff coverage is 98.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   41.65%   42.17%   +0.51%     
==========================================
  Files         216      217       +1     
  Lines       17134    17287     +153     
  Branches     2954     2954              
==========================================
+ Hits         7138     7290     +152     
+ Misses       9580     9562      -18     
- Partials      416      435      +19
Impacted Files Coverage Δ
scanomatic/ui_server_data/js/src/qc/bridge.js 87.87% <ø> (ø) :arrow_up:
...canomatic/ui_server_data/js/src/qc/StateBuilder.js 100% <100%> (ø) :arrow_up:
...atic/ui_server_data/js/src/api/getPhenotypeData.js 100% <100%> (ø) :arrow_up:
...omatic/ui_server_data/js/src/api/setCurveQCMark.js 100% <100%> (ø)
scanomatic/ui_server_data/js/src/qc/selectors.js 100% <100%> (ø) :arrow_up:
...atic/ui_server_data/js/src/qc/reducers/settings.js 100% <100%> (ø) :arrow_up:
scanomatic/ui_server_data/js/src/api/index.js 83.69% <100%> (+0.36%) :arrow_up:
...nomatic/ui_server_data/js/src/qc/reducers/plate.js 100% <100%> (ø) :arrow_up:
scanomatic/ui_server_data/js/src/qc/actions.js 96.15% <96.55%> (+1.15%) :arrow_up:
scanomatic/ui_server/general.py 23.48% <0%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7961ce...67de87d. Read the comment docs.