Bugs / features involving the animation frame counter

ScanMountGoat / ssbh_editor

View, edit, and validate models for Smash Ultimate

MIT License

32 stars 4 forks source link

Bugs / features involving the animation frame counter #60

Closed zrksyd closed 7 months ago

zrksyd commented 2 years ago

BUGS

As the animation plays, the frame counter will display to the hundredths digit. I'm not sure if this is intentional, but it's inconsistent with dragging the slider, which will only display whole numbers.
Dragging the frame counter text box will allow the value to go beyond the range of 0 to the max frame count.

FEATURES

Can arrow keys left and right be used to scrub the animation bar frame by frame while the bar is selected.
Can you add a loop checkbox (since looping is already the default, I would have the checkbox already checked when the program is booted.)
Can you add a frame speed? I know the game generally runs at 60 FPS but slowing it down or speeding it up can be useful such as for Fast Special Smash.

I think for the second and third feature requests, some inspiration can be taken from BrawlBox / BrawlCrate.

ScanMountGoat commented 2 years ago

SSBH Editor uses f32 internally for tracking the current "frame" and interpolates in between frames. This is necessary for handling different framerates and playback speeds. Not seeing whole numbers during playback is normal. The box showing negative values is just a visual bug and has been fixed.

I plan on implementing most of those changes for the animation bar in the future. Another helpful feature will be toggling whether or not SSBH Editor skips frames when rendering. This mostly applies to weaker devices with integrated graphics that may not be able to hit 60 fps consistently.

zrksyd commented 2 years ago

Since f32 is used for the current frame anyway, wouldn't it be best to be consistent and show hundredths place while using the slider too?

imod-commission commented 2 years ago

It might also be helpful to add a ".<" and ">." button to skip to the frame with expression keyframes

ScanMountGoat commented 2 years ago

Since f32 is used for the current frame anyway, wouldn't it be best to be consistent and show hundredths place while using the slider too?

You would very rarely want to directly select a value like frame 34.5. You can enter numbers with a decimal by clicking the text box and entering a value. I could show values like 34.00 while dragging, but I'm not sure it makes it any clearer.

It might also be helpful to add a ".<" and ">." button to skip to the frame with expression keyframes

There isn't a straightforward way of doing this. Suppose the animation is 60 frames long. Tracks will have either 1 frame and last the duration of the animation or 60 baked "keyframes". Most of the track values will be the same from frame to frame. Showing a visual indication for which frames have new values would be helpful, but it wouldn't be the same for every animation or track currently playing. I may look into graphing the values similar to the graph editor in Blender.

ThatNintendoNerd commented 1 year ago

I've implemented some new buttons to the animation bar. The outer two buttons allow for seeking to the start and end of an animation, respectively, and the inner two buttons advance and rewind an animation by one frame, respectively. Is this something that would be a welcome addition into SSBH Editor, or is a different approach desired?

zrksyd commented 1 year ago

I think it's alright but it might be best to have that on a new line rather than smushed against the right side