search

ScanTailor-Advanced / scantailor-advanced

ScanTailor Advanced is the version that merges the features of the ScanTailor Featured and ScanTailor Enhanced versions, brings new ones and fixes.
GNU General Public License v3.0
194 stars 8 forks source link

Feature request: negative margins #3

Closed AlexJacobs1977 closed 2 years ago

AlexJacobs1977 commented 2 years ago

The select content algorithm is not perfect. Please allow for negative margins in "margins". (top/bottom/left/right) Probably an easy fix.

vigri commented 2 years ago

Hi Alex,

I've made a quick check of your request. There seems to be no problem for alowing negative margins.

st st2

However, I do not want to make the decision myself whether it makes sense to allow negative margins or not. It would be good if someone from the other users could give his/her opinion.

AlexJacobs1977 commented 2 years ago

I'm unable to enter negative margins.

I'm also unable to go below zero using the arrows. Once the value hits zero, the arrow becomes grayed out.

I use windows 7, ST version 1.0.17 64 bit. Arrow

vigri commented 2 years ago

I expressed myself in a misleading way, sorry for that :)

As you wrote, the current release does not support negative margins. The screenshots above a from a quick test I made. I've enabled negative margins in the source code.

But:

However, I do not want to make the decision myself whether it makes sense to allow negative margins or not. It would be good if someone from the other users could give his/her opinion.

darnn commented 2 years ago

I'm not entirely sure what the use case for it, but I don't think it can hurt (except maybe with Auto Margins, which I can't comment on since I don't use it). At worst those who don't need it just wouldn't use it.

AlexJacobs1977 commented 2 years ago

To delete page numbers because scantailor fails to exclude them.

AlexJacobs1977 commented 2 years ago

Many thanks for considering this.

vigri commented 2 years ago

Next week I'll create a pre-release where this feature ist include.

Best regards

AlexJacobs1977 commented 2 years ago

Thank you! Big thanks!

   

Sent: Saturday, March 19, 2022 at 10:07 PM From: "Virgil Grigoras" @.> To: "vigri/scantailor-advanced" @.> Cc: "AlexJacobs1977" @.>, "Author" @.> Subject: Re: [vigri/scantailor-advanced] Feature request: negative margins (Issue #3)

 

Next week I'll create a pre-release where this feature ist include.

Best regards

— Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

AlexJacobs1977 commented 2 years ago

Would to see a release which uses negative margins. :)

vigri commented 2 years ago

Finally... https://github.com/vigri/scantailor-advanced/releases/tag/v1.0.18 ;-)