Closed zvezdochiot closed 1 year ago
Hi @vigri , @lightsilverberryfox .
The usefulness of the new thresholds has been confirmed (worst part of the scanned material): | Origin | Otsu | Sauvola | Wolf | Wolf | EdgePlus | BlurDiv |
---|---|---|---|---|---|---|---|
(600dpi) | (default) | (default) | (default) | (ws:20,c:0.75) | (ws:20,c:0.75) | (ws:20,c:0.75) | |
See threshold BlurDiv
.
[Feature request] thresholdAdjustment in other threshold. #59
Mod epdbta of release 1.0.18: https://github.com/ImageProcessing-ElectronicPublications/scantailor-advanced/releases/tag/v1.0.18
Hi! Is there any chance that the PRs here get merged and e.g. a new version 1.0.19 is released? It gets confusing because it seems that this PR is now released here https://github.com/ImageProcessing-ElectronicPublications/scantailor-advanced as 1.0.18
@alfish2000 say:
Is there any chance that the PRs here get merged and e.g. a new version 1.0.19 is released?
I don't hope so. Therefore, I release mods for existing releases. ;)
Is there any chance that the PRs here get merged and e.g. a new version 1.0.19 is released?
I don't hope so. Therefore, I release mods for existing releases. ;)
I'm confused by your "I don't hope so." Are you still OK with this being merged and included in a release here eventually? Otherwise, I think you should close the PR, mark it as draft, or similar.
Hi @mara004 .
I don't have enough experience with Qt and XML. If there are bugs, it will be difficult for me to eliminate them. If this PR enters the mainstream, I will be happy. Doubts are caused purely by lack of skill (especially in XML).
PS: During testing, I did not notice any failures.
Hi @mara004 , @lightsilverberryfox , @vigri .
Demo of new thresholds: | Origin | Otsu | EdgePlus |
---|---|---|---|
150dpi | 600dpi (d: 16) | 600dpi (d:16, ws: 20, c: 0.99) | |
Hi @mara004 , @lightsilverberryfox , @vigri .
Github Action: build-linux-qt5:
...
Err:12 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 libinput-bin amd64 1.20.0-1ubuntu0.2
404 Not Found [IP: 52.154.174.208 80]
Err:13 http://azure.archive.ubuntu.com/ubuntu jammy-updates/main amd64 libinput10 amd64 1.20.0-1ubuntu0.2
404 Not Found [IP: 52.154.174.208 80]
...
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/libi/libinput/libinput-bin_1.20.0-1ubuntu0.2_amd64.deb 404 Not Found [IP: 52.147.219.192 80]
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/main/libi/libinput/libinput10_1.20.0-1ubuntu0.2_amd64.deb 404 Not Found [IP: 52.147.219.192 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.
http://azure.archive.ubuntu.com/ubuntu/pool/main/libi/libinput/:
name | date | size |
---|---|---|
libinput-bin_1.20.0-1_amd64.deb | 2022-02-22 23:45 | 19K |
libinput-bin_1.20.0-1_i386.deb | 2022-03-02 14:09 | 24K |
libinput-bin_1.20.0-1ubuntu0.1_amd64.deb | 2022-05-02 06:13 | 19K |
libinput-bin_1.20.0-1ubuntu0.1_i386.deb | 2022-05-02 06:13 | 24K |
libinput-bin_1.20.0-1ubuntu0.3_amd64.deb | 2023-06-16 18:24 | 19K |
libinput-bin_1.20.0-1ubuntu0.3_i386.deb | 2023-06-16 18:24 | 24K |
Thu, 13 Jul 2023 15:49:44 +0300
Resolved:
I can tell you put a lot of effort in this PR and wanted to say thank you, you have also offered your input on other issues and bugs, so if vigri sees this, he may want to consider sending you an invitation to our organization so you have write access (I can't invite you myself, I don't have owner permissions).
apologies very much.
Thank you very much @zvezdochiot. As @lightsilverberryfox said: If you are interested, I can send you an invitation. Please let me know.
Regarding this PR: Pleasse see my "review".
@lightsilverberryfox say:
Is issue #59 also solved by this PR?
This PR closes the issues:
PS: Me, @plzombie and @trufanov-nok will oversee the STA fork at organization https://github.com/ImageProcessing-ElectronicPublications. Participation in https://github.com/ScanTailor-Advanced is not required.
PS: Me, @plzombie and @trufanov-nok will oversee the STA fork at organization https://github.com/ImageProcessing-ElectronicPublications. Participation in https://github.com/ScanTailor-Advanced is not required.
Wouldn't it be better to join efforts in one repo/organization, instead of all the fragmentation?
@mara004 say:
Wouldn't it be better to join efforts in one repo/organization
Maybe, but not now. I myself specialize in console utilities (GUI is not mine), @plzombie is busy with depress (it is more important to him), @trufanov-nok is in charge of STU. Everyone is busy with their projects.
PS: Until I figure out the STA (XML) projects, my help is over. I won't figure it out until I see how it's done. Such are the things.
Hi @mara004 , @lightsilverberryfox , @vigri .
New version? 1.0.19? I need for forums.
Hi @mara004 , @lightsilverberryfox , @vigri .
New version? 1.0.19? I need for forums.
Current:
I've uploaded 1.0.19 now. https://github.com/ScanTailor-Advanced/scantailor-advanced/releases/tag/v1.0.19
Guys it would be great to have the docs improves to explain the new thresholds, maybe with examples or when to use what. :)
Hi all, @ireun .
:warning: Don't clutter this repository! Documentation can be updated, but examples and stuff only in a separate repository. In this link only!
"Recommendations from the author":
Hi @vigri and @lightsilverberryfox .
:warning: This PR is just a recipe. I was only able to build
binarizeEdgePlus
into the general functionality. At the same time, I use the Sauvola options, which I don’t think is correct (the new threshold requires smaller area values and larger coefficient values). Due to this, projects with a new threshold are safely saved. Use this PR as a recipe.Good Luck.
Example
Links
Closes #47