search

ScanuNicco / Boat-Race

A boat racing game
0 stars 0 forks source link

Lap timer is incorrect #14

Closed zorbulator closed 5 years ago

zorbulator commented 5 years ago

screenshot 2019-01-10 at 8 10 32 am This isn't too important but it really shouldn't happen

ScanuNicco commented 5 years ago

I can add an if statement to check if the variables are the same but this is not a priority

zorbulator commented 5 years ago

This is absolutely a terrible way to solve the problem. The problem is caused by using different variables so the solution is to only use the lapMSeconds which is correct and have a function to turn it into a string. There shouldn't really be two variables anyway, lapString is only used for the timer display so it should stay in the timer function (you should have taken APCSP we learned about scope)

On Thu, Jan 24, 2019 at 10:22 AM scanunicco notifications@github.com wrote:

I can add an if statement to check if the variables are the same but this is not a priority

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ScanuNicco/Boat-Race/issues/14#issuecomment-457302931, or mute the thread https://github.com/notifications/unsubscribe-auth/AYotz7o_Ym9cw2VObbi2-JbqPOLwMOytks5vGfnKgaJpZM4Z50_0 .

zorbulator commented 5 years ago

This has been fixed for now but could be done better