ScaredKurufinve / Way-of-the-shield

4 stars 1 forks source link

Turn-based problem #8

Open HerryZheng8 opened 1 year ago

HerryZheng8 commented 1 year ago

When I use turn-based games,Combat will get stuck,Switch to the instant system and then switch back to the combined system,For the game to work

ScaredKurufinve commented 1 year ago

Do you have this problem only with my mod? I know such problem was present in the base game too. If it happens only with my mod, are there any common factors to its occurence? For example, only when you activate certain abilities or something similar? I am unable to reproduce this problem myself.

HerryZheng8 commented 1 year ago

I'm sure, because I haven't had this problem since I uninstalled this MOD

HerryZheng8 commented 1 year ago

I'm not sure exactly how it happened, but maybe I changed Seelah's class to divine guardian

ScaredKurufinve commented 1 year ago

I am terribly sorry, but I am unable to find any evidences of such a bug. I asked people on Discord who also use this mod, and they also say they never encountered anything like this. You may still try to take the Way of the Shield.dll file from the mod's Debug folder, put it inside the Assemblies folder instead of the existing one and (after enabling the Debug option in the mod settings) play until you encounter the bug to generate the detailed log which I can analyze. But I doubt I will be able to find anything to detect the issue.

HerryZheng8 commented 1 year ago

OK,I will try.

Bigeam commented 1 year ago

I also encountered this bug. Occasionally appears while under the influence of the HolyShield

ScaredKurufinve commented 1 year ago

I also encountered this bug. Occasionally appears while under the influence of the HolyShield

Hm 🤔 I will try to reproduce. But it kinda sounds like some stupid base game problem with area effects.

KTVSUN commented 1 year ago

I have the same issue, only with my 2 mounted characters. Edit: problem disappears when i desactivate the option for "allow couching spears". Edit 2: nope still doing it Hope it helps and you ll manage to fix it, great mod.

ScaredKurufinve commented 1 year ago

I have the same issue, only with my 2 mounted characters. Edit: problem disappears when i desactivate the option for "allow couching spears".

How curious. I can't reproduce that. Do your mounted characters actually use couched spears or only the setting is active and they use some other weaponry? Can you send me the game log after this issue happens?

KTVSUN commented 1 year ago

It started doing it again and i realized by default the option to use shield bash is active, none of these characters had shields equiped so i deactivated it and the combat went on without problem. Cant test more today will do tomorrow. EDIT here are logs with the problem happening. EDIT 2 i was wrong, it s still doing it even with thatr option desactivated. I also tried activating all setup in mod config or disabling all. i add a screenshot of how it looks. Player.log GameLog.zip Untitled

ScaredKurufinve commented 1 year ago

Oh, that's the PredictionPanelFiveFeetActionVM problem. Hm. I don't think we ever figured out what causes it, but your info may help. I wonder if it happens because of interactoin with some other mod.

ScaredKurufinve commented 1 year ago

@KTVSUN Hm, may I ask you to completely delete the mod, make sure it's not in the game folder or in the UMM folder or in the AppData\LocalLow\Owlcat Games\Pathfinder Wrath Of The Righteous\Modifications folder (or whereever your OS places it) and then reinstall? The log contains an error about a badly configured blueprint, and I'm fairly sure I fixed the last one in version 2.0.7 and it may potentially be the reason. Unfortunately, due to a bug in OwlCode the error message can not display correctly which exactly buff that is. If a clean re-install of the mod won't help, substitute the game dll with the file from attachment as seen on the screenshot and send me new Game Log again (you may want to back up the original in case something goes wrong, but it shouldn't). 2 Assembly-CSharp.zip

KTVSUN commented 1 year ago

Good morning, removed mod from umm folder and game folder, downloaded the latest version again and still have the problem. Got to work a bit then will do the dll swap. In meantime logs until the moment seelah stopped responding. GameLog.zip Player.zip

KTVSUN commented 1 year ago

Bqcked up my dll, uploaded then one you sent. Ran the game again at the same fight and this time instead of blocking when it s seelah s turn it just skipped her everytime. I checked and she had no debuff that would justify this. Here are the logs Player.zip GameLog.zip

KTVSUN commented 1 year ago

I also noticed my log is huge when running your mod and i believe it s because it s spammed with : [479.9473 - Default]: Exception occured! Kingmaker.GameModes.GameMode.Tick() (at :0) Kingmaker.Game.Tick() (at :0) Kingmaker.Runner.Update() (at :0)

[479.9482 - Default]: Object reference not set to an instance of an object at Kingmaker.View.MapObjects.AreaEffectView.Contains (Kingmaker.EntitySystem.Entities.UnitEntityData unit) [0x00089] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.EntitySystem.Entities.AreaEffectEntityData.ShouldUnitBeInside (Kingmaker.EntitySystem.Entities.UnitEntityData unit) [0x000fb] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.EntitySystem.Entities.AreaEffectEntityData.UpdateUnit (Kingmaker.EntitySystem.Entities.UnitEntityData unit) [0x00018] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.EntitySystem.Entities.AreaEffectEntityData.UpdateUnits () [0x00102] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.EntitySystem.Entities.AreaEffectEntityData.UpdateViewAndUnits () [0x0009c] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.EntitySystem.Entities.AreaEffectEntityData.HandleEnd () [0x00000] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.EntitySystem.Entities.AreaEffectEntityData.Tick () [0x0000e] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.Controllers.AreaEffectsController.EffectTick (Kingmaker.EntitySystem.Entities.AreaEffectEntityData areaEffect, Kingmaker.Controllers.Optimization.FrameContext context) [0x00000] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.Controllers.AreaEffectsController+<>c.b__4_0 (Kingmaker.EntitySystem.Entities.AreaEffectEntityData data, Kingmaker.Controllers.Optimization.FrameContext context) [0x00000] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.Controllers.Optimization.TickProlongationEntityPool2[T,TContext].Tick (System.Action2[T1,T2] tickAction, TContext frameContext) [0x00057] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.Controllers.Optimization.MixedTickProlongationEntityPool2[T,TContext].Tick (System.Action2[T1,T2] tickAction, TContext frameContext) [0x00031] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.Controllers.AreaEffectsController.Tick () [0x00019] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

at Kingmaker.GameModes.GameMode.Tick () [0x0002f] in <9fbdaaba94e842ff9fe97bf4617a0789>:0

I removed your mod, loaded my last save before i installed it and checked the log after 1 fight. I dont have any instance of this spam while there are more than 13000 in a few minutes of play with it installed.

Hope it helps

ScaredKurufinve commented 1 year ago

The AreaEffectView spam comes from Summer Golems. They have bugged aura. (This is a problem of the base game.) You can see it coming from the error mesage Area from GolemSummerAura: invalid shape, cannot create view.

The problem with broken turn based mode probably happens because of [448.1458 - Default]: Exception in UnitBuffsController on unit Unit[AnimalCompanionUnitHorse]#37CA2 which was present in your first 2 logs, but a I said, the error reporting is broken and would not tell which exactly buff that is. But somehow this error is not present at all in the last log you sent and now I'm not really sure.

Edit. Can you do tests in a dungeon without golems? Edit2. There's also a shit ton of error spam from the Artifact_HolySymbolOfIomedaeBuff... Edit3. The closest relevant thing I see in this log is an error happening because of BuffPoisonStatDamage. Not sure which enemy might apply it.

KTVSUN commented 1 year ago

Hello, i removed it for now and rolled back to a previous save. Will try to reinstall and test ina dungeon without golems

ScaredKurufinve commented 1 year ago

@KTVSUN after giving a second look to the log, I noticed this error which was likely the one causing the interface crash: [481.7680 - Actions]: Exception in game logic: .Conditional#Nameless component of type Kingmaker.Designers.EventConditionActionSystem.Actions.Conditional from the blueprint NULL OWNER BLUEPRINT [Object reference not set to an instance of an object] () And there are two problems with it: 1) I don't understand why the problem still persist despite the error being somewhat handled by the code. 2) I don't know what causes it - as you can see from the message, it's caused by a nameless Conditional element coming from a null blueprint. I don't know how can this be theoretically possible. Additionally, the reason why the error happens in the first place is because this Conditional is lacking the IfTrue branch and I double-checked yesterday, but all of my Conditionals do have it. Without any additional hints, I can't even start guessing how to fix it.

Bakaten commented 1 year ago

Hi Kuru, I'm currently playing on 2.0.8 and so far is fine, but will update you in the future if the problem reoccurs. Just to add that based on my past playthrough, it only happened specifically on Seelah's horse acquired through divine bond. It is the horse's turn that get stucked (both normal and black horses), mounted as well as unmounted (in the case of mounted, Seelah will also get stucked). All other companions' pet ( in my case they are dogs) are fine. Haven't tried with horses or any other animals on other companions' though. Hope this can help narrow down the source of the problem. Cheers.

KTVSUN commented 1 year ago

Thanks for your hard work, next week i ll have more time to play and will reinstall your mod and see what happens.

ScaredKurufinve commented 1 year ago

@Bakaten Thank you for the info! Did your horse happen to have any teamwork feat when the problem was happening? I'm thinking if maybe there's a teamwork feat broken and the bug happens only when the character and the pet are not close enough for it to activate. That being said, I'm still unable to reproduce, but very grateful to you for taking the time to report a lot of valuable info.

KTVSUN commented 1 year ago

Traveling so answering through email. My horses all have outflank. Next week my wife is traveling to Europe soooo free time to play. I'll see what I encounter. Hopefully nothing 😁

On Wed, Jun 7, 2023, 14:25 ScaredKurufinve @.***> wrote:

@Bakaten https://github.com/Bakaten Thank you for the info! Did your horse happen to have any teamwork feat when the problem was happening? I'm thinking if maybe there's a teamwork feat broken and the bug happens only when the character and the pet are not close enough for it to activate. That being said, I'm still unable to reproduce, but very grateful to you for taking the time to report this.

— Reply to this email directly, view it on GitHub https://github.com/ScaredKurufinve/Way-of-the-shield/issues/8#issuecomment-1581459925, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7PD2EXTLSPPPFHWVNRSX2TXKDPUHANCNFSM6AAAAAAVZBCDZY . You are receiving this because you were mentioned.Message ID: @.***>

Bakaten commented 1 year ago

@Bakaten Thank you for the info! Did your horse happen to have any teamwork feat when the problem was happening? I'm thinking if maybe there's a teamwork feat broken and the bug happens only when the character and the pet are not close enough for it to activate. That being said, I'm still unable to reproduce, but very grateful to you for taking the time to report a lot of valuable info.

Hi Kuru, nope, my horse only has crane style (and all it's prereqs) and fighting devensively. But I think mounting the horse is as close enough as it is :P, but the bug still happened. But so far on 2.0.9, blasting through chapter one without any problems.

Cheers