search

ScarletsFiction / SFMediaStream

HTML5 media streamer library for playing music, video, playlist, or even live streaming microphone & camera with node server
MIT License
101 stars 30 forks source link

Some precisions #13

Open yarekc opened 3 years ago

yarekc commented 3 years ago

Hey, this project looks awesome. I have some questions

0) I cannot find the nodejs server part in source code.

1) is there an online demo so I can test it ?

2) I guess it works fine with chrome and FF. But did you try it with Safari (it has probably a different mediaRecorder API as usual)

Regards

StefansArya commented 3 years ago

Hi,

  1. I cannot find the nodejs server part in source code.

There's some example to work with Node.js in the /example folder, I haven't make it as a library for Node.js server. Because I think it's better to build a streaming server with language like C, Rust, or Golang.

  1. is there an online demo so I can test it ?

Hmm, sorry it doesn't have yet. But looks like Heroku now support WebSocket, maybe I should try to make an online demo later. Actually you can just:

  1. I guess it works fine with chrome and FF. But did you try it with Safari (it has probably a different mediaRecorder API as usual)

Thanks for remind me, but sadly me and my friends only have Windows instead of MacOS so I haven't test it on Safari. If you found any error when using Safari browser feel free to fill new issue. Maybe I can fix it by some provided info.

yarekc commented 3 years ago

Thanks for answers I tested some demos:

For me this is probably the most interesting demo to test. But I have no idea how. Could you add a readme.txt on how to run it ?

There is a readme.txt that just says "Have bug :("

Regards

StefansArya commented 3 years ago

Hi sorry for being away because I have some other project to be done.

(you should however change presenterID: to socketID : it is confusing)

Well, both presenter and streamer can have a socketID. I think it's easier to understand since it's pointing the presenter. It could be changed on your implementation for the server.

p2p-video-stream : looks like server files are missing

Yep, my last demo for that still not perfect and have problem with the browser's video decoder. Sometime it's working and sometime it's broken. If you want to try it you can just replace ScarletsAudioStreamer with ScarletsVideoStreamer like on the readme. But I can't guarantee it would work 100% 😅.

I'm planning to redesign it and use WebRTC instead of sending video chunk through the server. But I prefer to redesign the other feature too, and it would cause some breaking changes..

ahwelgemoed commented 3 years ago

Hi Sorry to JUMP on the back of this - But @StefansArya I pulled the Project and cannot seem to get group call to work. Can it work with just http and local host or must it be https with SSL ?

StefansArya commented 3 years ago

Hi @ahwelgemoed, Does the the browser give any error message from the DevTools's console?

It should work on http and localhost, because on the group-call example I setup it up to run on http://localhost:8000, and have tested it on Chromium v88.0.

But after I test it on Firefox, looks like it has a timing problem and the audio got delayed when being used as a streamer, and as a presenter I just realized if it has an error. It will need some investigation for the delayed audio.