search

Scarygami / location-history-json-converter

Convert the Location History JSON File from Google Takeout into a useable format
Apache License 2.0
468 stars 117 forks source link

startendtime (attempt 2) #32

Closed ChickenSupreme closed 4 years ago

ChickenSupreme commented 4 years ago

This pull request adds --starttime and --endtime arguments. The arguments are only used when the corresponding date argument is set (e.g. starttime requires startdate and so on).

For example, --startdate 2012-05-01 --starttime 07:00 will use "2012-05-01 07:00" as the start date/time and --enddate 2012-05-02 --endtime 07:00 will use "2012-05-02 06:59:59.999999" as the end date/time.

Note that this improves on my previous (closed) pull request by making the endtime argument much more intuitive. It also leaves the existing functionality exactly the same so omitting the starttime and endtime arguments should run exactly as before.

Please do review the code before merging as I am new to GitHub and haven't done any serious coding in a decade.

Scarygami commented 4 years ago

Looks good, thanks for the PR :)