search

Scarygami / location-history-json-converter

Convert the Location History JSON File from Google Takeout into a useable format
Apache License 2.0
468 stars 117 forks source link

Fixed issue with current timestamp key instead of former timestampMs.… #48

Closed motophil closed 2 years ago

motophil commented 2 years ago

Fixed issue with current timestamp key instead of former timestampMs. Works with old and new version of takeout. ToDo: fix chronological. Based on the contribution of @rickprice, included in this pull request with his permission (thanks!)

Scarygami commented 2 years ago

Hi, thanks a lot for preparing this PR. I noticed that you have an open Todo in there for the sorted/chronological option. Would it be possible for you to implement this todo before I merge the PR?

motophil commented 2 years ago

Hi Gerwin,

I didn't look into it at first since my Python is a bit rusty, but looking into it a pythonic fix was pretty easy. So: Fixed.

dfmore commented 2 years ago

@Scarygami the fix proposed here worked for me

Scarygami commented 2 years ago

Thanks for working on this and sorry for the delay in merging.