No need for coping particle object when defining a Lab

ScattPy / scikits.scattpy

Light Scattering Methods for Python

scattpy.github.com

14 stars 3 forks source link

No need for coping particle object when defining a Lab #3

Open vinokurov opened 13 years ago

vinokurov commented 13 years ago

When a Lab object is initialised a copy of a Particle object is created and is stored inside of it. I think there's no need for this. Lab.particle can be a link to a Particle object.

However, this pickling of a Lab object with link-type particle property should be tested. If it doesn't pickle well, we will have to stay with copying Particle objects

MaXal commented 13 years ago

Is there any kind of unit tests? Or reference examples? If it's not what kind of testing do you mean?

vinokurov commented 13 years ago

Unfortunately still there are no unit tests implemented. However they are highly required as regression bugs occur very often.

MaXal commented 13 years ago

Ok, I'll try to implement something for new and may be old code.