ScatterCo / Depthkit.js-deprecated

🎞 A plugin for using Depthkit's volumteric captures in Three.js
https://depthkit.tv
MIT License
33 stars 11 forks source link

Add a way to change the mesh scalar before a clip is loaded #10

Open tim-depthkit opened 4 years ago

tim-depthkit commented 4 years ago

Calling setMeshScalar before loading a clip causes an error, so the only other way to do it is by setting this.meshScalar directly, which is supposed to be a "private" member.

This is an issue because using the default mesh scalar may cause some devices (iPhone, iPad, etc) to run out of memory before you have the opportunity to set it to something lower.

We should either update setMeshScalar to not attempt to rebuild geometry before a clip has been loaded, or add some other way to specify the default mesh scalar, in the constructor for example.