ScatterCo / Depthkit.js-deprecated

🎞 A plugin for using Depthkit's volumteric captures in Three.js
https://depthkit.tv
MIT License
33 stars 11 forks source link

A-Frame Support (for versions >=1.1.0) #16

Open vulture-boy opened 2 years ago

vulture-boy commented 2 years ago

Hello! Appreciate the work that you've put into this. This is probably outside of the scope of the base DepthKit.js, but I wanted to mention that at present, the available library support for A-Frame does not seem to work with A-Frame versions >=1.1.0 due to the transition from THREE.Geometry to THREE.BufferGeometry in 2019 (if I understand correctly). https://github.com/juniorxsound/DepthKit-A-Frame

Works just fine with A-Frame 0.8.2, however. From the looks of the code, DepthKit for A-Frame seems to contain a minified version of DepthKit.js inside its core .js file.

In any case, I wanted to bring this up in case anyone was interested supporting the A-Frame community by bringing this extension up to speed, since it seems apparent that the people working on this fork are very knowledgeable on DepthKit.js and the A-Frame support hasn't been updated in 4 years from the looks of things.

Thanks for your time!