search

ScatterHQ / machinist

A library for constructing finite state machines
Apache License 2.0
57 stars 12 forks source link

Fix for trivialInput so that instances produced are providers of IRichInput #15

Closed cyli closed 10 years ago

cyli commented 10 years ago

Have trivialInput produce an implementer of IRichInput, whose instances will be providers of IRichInput.

Fixes #14

I don't know if #7 means to deprecate or delete trivialInput entirely, but this way there are smaller changes.

exarkun commented 10 years ago

Thanks! This looks like the correct fix for the existing buggy behavior (independent of whether trivialInput eventually gets the axe). In addition to the simple inline comments, please add a bugfix news fragment (the kind you know from Twisted) to machinist/topfiles (and hopefully I'll figure out a way to use NewsBuilder to actually generate a news file :smile:).

cyli commented 10 years ago

@exarkun Thank for the review! I think all the review comments have been addressed - also, you should totally coordinate with @glyph because he is trying to do the same on another project with the news files. :)

exarkun commented 10 years ago

Thanks!