ScatterHQ / machinist

A library for constructing finite state machines
Apache License 2.0
57 stars 12 forks source link

Make eliot optional #31

Closed exarkun closed 10 years ago

exarkun commented 10 years ago

This makes machinist also work when eliot is not installed.

Fixes #6.

wallrj commented 10 years ago

Thanks @exarkun

I think this looks good. Sorry this took a long time. I was confused by the duplicate HL and HC repositories and then further confused because I checked out your other eliot logging removal branch optional-eliot-6.

Notes:

I'd like to have run the docs/turnstile.py with and without eliot installed and seen the log output (or lack of), but that example seems to be missing a library.

(machinist)(master ? =)[~/.../HybridLogic/machinist]$ python doc/turnstile.py
Traceback (most recent call last):
  File "doc/turnstile.py", line 9, in <module>
    from turnstilelib import TurnstileController
ImportError: No module named turnstilelib

Please answer or address the inline comments and then merge, unless there are any other checks that you'd like me to do.

exarkun commented 10 years ago

I was confused by the duplicate HL and HC repositories

Sorry about that. Since I've only gotten negative feedback on this choice so far maybe I'll give up the idea.

I'd like to have run the docs/turnstile.py with and without eliot installed and seen the log output (or lack of), but that example seems to be missing a library.

... yea. That library doesn't exist, I made it up for the example. I'm going to write some real, runnable examples next so hopefully this issue will go away.

Thanks!

coveralls commented 10 years ago

Coverage Status

Coverage increased (+0.87%) when pulling 6f60190acace5f8dc9eb22648d04c352b5057968 on hybridlogic:retry-optional-eliot-6 into 572d90c3d019cb428a1e2807a8e3419bcd37c953 on hybridcluster:master.