Studymaster web - Githubissues

SceneMaker / VisualSceneMaker

Visual SceneMaker is an authoring tool for creating interactive presentations aimed to non-programming experts. It supports the modeling of verbal and non-verbal behavior of Virtual Characters and robots. Therefore, it provides users with a graphical interface and a simple scripting language that allows them to create rich and compelling content.

http://scenemaker.dfki.de

Other

18 stars 11 forks source link

Studymaster web #209

Closed algor1th closed 3 years ago

algor1th commented 3 years ago

Needed to merge:

[x] GUI improvements
[x] Change logging from System.out to logger
[x] Loading the page when the REQUEST has been already issues should visualise the form, not blank
[x] On a REQUEST form: when selecting cancel, variables should not be set.
[x] After clicking Submit or Cancel, the web GUI should get blank.

fnunnari commented 3 years ago

Hi. Can you review again this version? Both the app and the documentation are updated.

fnunnari commented 3 years ago

New code is there. Caching problem on the Java side solved. Now @chiragbhuvaneshwara can work on improving the web part.

chiragbhuvaneshwara commented 3 years ago

New code is there. Caching problem on the Java side solved. Now @chiragbhuvaneshwara can work on improving the web part.

Updated the GUI with required functionality. Please check.

Remaining task:

[ ] Always display all of the project variables in a different frame/div of the web page

fnunnari commented 3 years ago

Hi @chiragbhuvaneshwara. Two more small bugs.

When all fields are empty, clicking submit shows one pop up window for each of the empty fields, warning that the field should be filled. However, on the VSM side the request_result is set and the project continues;
When clicking either submit or cancel the form is correctly hidden, but the buttons remain visible. Buttons should be hidden as well, and a label like "No active requests." should be displayed.

chiragbhuvaneshwara commented 3 years ago

Hi @chiragbhuvaneshwara. Two more small bugs.

When all fields are empty, clicking submit shows one pop up window for each of the empty fields, warning that the field should be filled. However, on the VSM side the request_result is set and the project continues;

When clicking either submit or cancel the form is correctly hidden, but the buttons remain visible. Buttons should be hidden as well, and a label like "No active requests." should be displayed.

Implemented requested features.

fnunnari commented 3 years ago

To me, everything works fine and smooth. I also performed a final code cleanup. The last missing feature has been transferred as issue #218. I suggest merging to use this plugin asap in production for the MindBot project.