search

SceneView / sceneform-android

Sceneform Maintained is an ARCore Android SDK with Google Filament as 3D engine. This is the continuation of the archived Sceneform
https://sceneview.github.io/sceneform-android/
Apache License 2.0
628 stars 147 forks source link

Add support for using sceneform sdk as a dynamic module #450

Closed mrunal-upadhyay closed 1 year ago

mrunal-upadhyay commented 1 year ago

Currently, Sceneform sdk does not support and cannot be used as a dynamic module to make use of the https://developer.android.com/guide/playcore/feature-delivery to reduce app size.

This PR resolves https://github.com/SceneView/sceneform-android/issues/441 bug.

I have made changes as described at https://developer.android.com/guide/playcore/feature-delivery#resource-uri for supporting dynamic module.

@ThomasGorisse , @RGregat, @grassydragon, @nvictornvictor, Please have a look at it. This change allows to use the sdk as an Android dynamic modules without impacting the current behavior.

Testing:

grassydragon commented 1 year ago

Hi! Thank you for the pull request! We haven't made new releases for Sceneform in a while since we are now focusing more on Sceneview that is being developed in Kotlin: https://github.com/SceneView/sceneview-android Are you expecting us to release a new version of Sceneform including your changes?

mrunal-upadhyay commented 1 year ago

Thank you @grassydragon for reviewing the request.

It would be of great help if it is possible to release a new version of Sceneform with these changes. This would allow developers who are on java version to make use of Android dynamic modules to help them in reduction of apk size.

Thanks, Mrunal

On Tue, Jun 6, 2023 at 10:09 PM Nikita Zaytsev @.***> wrote:

Hi! Thank you for the pull request! We haven't made new releases for Sceneform in a while since we are now focusing more on Sceneview that is being developed in Kotlin: https://github.com/SceneView/sceneview-android Are you expecting us to release a new version of Sceneform including your changes?

— Reply to this email directly, view it on GitHub https://github.com/SceneView/sceneform-android/pull/450#issuecomment-1579903473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAICCN6C3BGPRGUSOVIBSVTXKAEHZANCNFSM6AAAAAAYWDLXZA . You are receiving this because you authored the thread.Message ID: @.***>

-- Cheers, Mrunal

mrunal-upadhyay commented 1 year ago

Hello @ThomasGorisse , @RGregat, @grassydragon, @nvictornvictor,

Would anyone be able to help with merging the change and releasing the sdk?

grassydragon commented 1 year ago

Hi! I'll merge it and try try to release this week.

mrunal-upadhyay commented 1 year ago

Thanks @grassydragon for helping with the merge. Do you know when the release will be available on maven? I see that the release is being tagged but not yet available on maven.

grassydragon commented 1 year ago

Hi! I'll remind Thomas about releasing an update (he is the only one who can do that).

mrunal-upadhyay commented 1 year ago

@grassydragon , Would it be possible to connect with Thomas to help release the sdk?

grassydragon commented 1 year ago

Hi! Yes, I'll remind him again about that. I'm really sorry about the delay, probably, Thomas was busy and missed my message. You can also join our Discord server so we can communicate with Thomas together.