search

SceneView / sceneview-android

SceneView is a 3D and AR Android Composable and View with Google Filament and ARCore. This is a Sceneform replacement in Kotlin
Apache License 2.0
758 stars 151 forks source link

Update model viewer sample to use version 2.0.2 #405

Closed waliahimanshu closed 3 months ago

waliahimanshu commented 5 months ago

Why?

The model viewer sample appears to be broken and mostly crashes with this stacktrace.

error with vers 2.0.0

6:41.120 12387-12387 libc                    io.....sceneview.sample.modelviewer  A  Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x34 in tid 12387 (ple.modelviewer), pid 12387 (ple.modelviewer)
2024-01-29 12:46:41.385 12460-12460 DEBUG                   pid-12460                            A  Cmdline: io.github.sceneview.sample.modelviewer
2024-01-29 12:46:41.385 12460-12460 DEBUG                   pid-12460                            A  pid: 12387, tid: 12387, name: ple.modelviewer  >>> io.github.sceneview.sample.modelviewer <<<
2024-01-29 12:46:41.385 12460-12460 DEBUG                   pid-12460                            A        #00 pc 00000000001005f8  /data/app/~~37GEldN1njsu6VQ93PZrSw==/io.github.sceneview.sample.modelviewer-sbf7i26kKGjPQROYNCyKdg==/base.apk![libfilament-jni.so](http://libfilament-jni.so/) (offset 0x129b000) (BuildId: 150857324dff6bb527284e2c4c59163363c52f89)

What

I am trying to migrate the sample from 2.0.0 to 2.0.2. I managed to use the newer api, however I am not getting desired results.

Issues

  1. It seems I am missing something about model or camera positions. Please see the comment below to how the model is appearing. https://github.com/SceneView/sceneview-android/pull/405#discussion_r1471962596
  2. ~The indirect light environment is not showing in the 3d scene background~ able to make it work with :
 sceneView.environmentLoader.loadHDREnvironment(hdrFile).apply {
                sceneView.indirectLight = this?.indirectLight
                sceneView.skybox = this?.skybox
            }
ThomasGorisse commented 5 months ago

Sorry, I just saw that the camera node is already at z = 4.0f so maybe move to scaleToUnit = 1.0f

waliahimanshu commented 5 months ago

@ThomasGorisse thanks for your reply, sorry I was not very clear.

In the previous version, we could view the whole model (wooden, silver and metallic textures ) similar to this and autoplay its animation!

image

After the update I could only last metallic part of it, please see the video for how its appearing? Is it worth continue using this model?
I am not sure whats causing this model too appear only partly.

https://github-production-user-asset-6210df.s3.amazonaws.com/7093480/301652679-b4989f98-679e-460c-a0f6-b53ec1d35b93.mp4?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAVCODYLSA53PQK4ZA%2F20240202%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20240202T145930Z&X-Amz-Expires=300&X-Amz-Signature=82f869e80156b4b5c9c7eda01f5c000aae731985fc2f8c63f49a8d67cbf480aa&X-Amz-SignedHeaders=host&actor_id=7093480&key_id=0&repo_id=426414439