ScenicFramework / scenic

Core Scenic library

Apache License 2.0

1.99k stars 137 forks source link

Stricter font_metrics requirement #219

Closed wojtekmach closed 3 years ago

wojtekmach commented 3 years ago

Description

Scenic uses FontMetrics.from_binary/1 which is no longer there in v0.5.x.

Types of changes

[x] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist

[x] Check other PRs and make sure that the changes are not done yet.
[x] The PR title is no longer than 64 characters.

codecov[bot] commented 3 years ago

Codecov Report

Merging #219 (3ea6979) into master (87c56e2) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   86.66%   86.66%           
=======================================
  Files          87       87           
  Lines        2340     2340           
=======================================
  Hits         2028     2028           
  Misses        312      312

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87c56e2...3ea6979. Read the comment docs.

boydm commented 3 years ago

@axelson is correct. It is just a huge release that's just killing me to get through. Almost there...

boydm commented 3 years ago

This has been published to hex as version v0.10.5

wojtekmach commented 3 years ago

Awesome, updated my scenic demo accordingly https://github.com/wojtekmach/mix_install_examples/blob/main/scenic.exs ;)