Fix tests on Elixir 1.15 - Githubissues

ScenicFramework / scenic

Core Scenic library

Apache License 2.0

1.99k stars 137 forks source link

Fix tests on Elixir 1.15 #335

Closed axelson closed 1 year ago

axelson commented 1 year ago

Description

Starts running tests on Elixir 1.15 with OTP 26

The map ordering change in OTP 26 caused many tests to break because they were implicitly relying on a not guaranteed order.

Adds machete to add a sorted_list test helper (instead of changing many assertions to be split across two statements)

Motivation and Context

Allows running the tests on the most recent version of Elixir and OTP

Types of changes

[ ] Bug fix (a non-breaking change which fixes an issue)
[ ] New feature (a non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist

[x] Check other PRs and make sure that the changes are not done yet.

axelson commented 1 year ago

Yeah I really like having machete in my toolbox! I wish it was used more often.