glfw - Fix hidden cursor on re-focus and window repaint

mneumann commented 1 year ago

Related bug report: https://github.com/ScenicFramework/scenic/issues/324
On some Window managers (e.g. CTWM) the window is not repainted when another window is moved over it. Add refresh_window_callback and "redraw" (reuse reshape_window for now...).
At least on Hikari (Wayland), when the cursor leaves the window and re-enters the window, the cusor was no longer visible. This commit fixes this issue by adding a focus_window_callback and explicitly setting the cursor when focus is regained.
NOTE: This might (or might not) show a cursor where no cursor is wanted (touch-screen devices?). To fix this, the glfwSetCusor and glfwSetInputMode calls in focus_window_callback should be conditionalized by a global per-device setting, whether a cursor is desired or not.

crertel commented 1 year ago

Great work! Let's see if we can get somebody to verify the touch-screen behavior, but this is super neat!

crertel commented 1 year ago

@mneumann would you mind updating against current head of main so we can get the CI signoff? Sorry for the delay. :)

mneumann commented 1 year ago

@crertel no worries. there we go: rebased to recent main :)

mneumann commented 1 year ago

@crertel ping :).

crertel commented 10 months ago

Sorry, sorry, @mneumann last rebase and we'll get it merged!

(doing end-of-year cleanup)

mneumann commented 10 months ago

@crertel no worries! there we go - rebase done :)

ScenicFramework / scenic_driver_local