ScenicFramework / scenic_driver_local

Local rendering driver for Scenic
Apache License 2.0
10 stars 13 forks source link

Fix failing build on macOS #36

Closed ohrite closed 1 year ago

ohrite commented 1 year ago

Description

Include OpenGL/gl3.h on macOS in c_src/defvice/gl_helpers.c

Motivation and Context

I'm building the latest head of main on macOS Ventura, and ran into a classic macOS OpenGL header issue: fatal error: 'GLES3/gl3.h' file not found.

It appears this issue was introduced in https://github.com/ScenicFramework/scenic_driver_local/commit/51f91bf17d0ccec250508b6558efb909e96d1c87

The codebase is already using the __APPLE__ cpp directive for conditional includes in c_src/nanovg/nanovg_gl_utils.h for similar reasons.

Types of changes

Checklist

crertel commented 1 year ago

Thanks for this!

axelson commented 1 year ago

I'm not sure how to trigger the build on this. I'm going to go ahead and merge.

axelson commented 1 year ago

And the build succeeded on main: https://github.com/ScenicFramework/scenic_driver_local/actions/runs/5845487259/job/15849656829