search

ScenicFramework / scenic_driver_local

Local rendering driver for Scenic
Apache License 2.0
10 stars 13 forks source link

Pull in rrectv work #67

Closed crertel closed 4 months ago

crertel commented 6 months ago

This finishes pulling in @GPrimola 's work that I merged in #17 .

We'll rebase here and have staging ground to pull in the functionality to the Cairo backend too.

crertel commented 4 months ago

Ah, hell's bells...okay @ringlej I'm caught back up on this--is there any chance you can grab the Cairo side of this, or should I grab it? I think you've got a bit more context there than I do.

ringlej commented 4 months ago

The only thing I'd mention here is that there isn't a Cairo implementation provided so anyone using it with Cairo will get a log message if the function is attempted with no rendering done. That said, I'd rather this not hold up a release.

ringlej commented 4 months ago

Right now I don't have the cycles to tackle this for Cairo.

crertel commented 4 months ago

Makes sense. Let's do a fast-follow then.

(let's here == "Chris will give it a shot later". not trying to give you work!)

GPrimola commented 4 months ago

@crertel @ringlej I can do it for Cairo too! I'm almost sure when I did it for NVG there wasn't support for Cairo yet. Maybe? 🤔 Anyway, will do it in another PR. Thanks!! :)

crertel commented 4 months ago

'preciate ya, @GPrimola!