Scenwise / widget-demos

0 stars 0 forks source link

16 further development on rijkswaterstaat demo #17

Closed LibbyTang closed 4 months ago

LibbyTang commented 4 months ago

16

netlify[bot] commented 4 months ago

Deploy Preview for parking-widget-demo ready!

Name Link
Latest commit 045833708cdfadc1609fbc36755cdb5720b229cc
Latest deploy log https://app.netlify.com/sites/parking-widget-demo/deploys/6668c2b914bfc400088c3029
Deploy Preview https://deploy-preview-17--parking-widget-demo.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ellyoana commented 4 months ago

Nice work! Can you make the text "No accidents found." a bit more centered and smaller? It looks a bit out of place now. Also, maybe we should change it to something more instructive, e.g. "Please select a road side to view accidents." or something along these lines.

Also, I don't think the filtering works well with the new addition. See example below, in which there are 4 points on map, but only 3 in the list (and the one highlighted is not in the list). Can you double check this? I would ask whether we need to have the filtering fully functional by tomorrow or not, maybe we should not merge this if the filtering is a must

image
LibbyTang commented 4 months ago

"No accidents found."

Thank you for the feedback! For the first problem, because the length of the list is listed, I just simply removed "No accidents found."