search

Sceptre / sceptre-sam-handler

A Sceptre template handler for AWS Serverless Application Model (SAM)
Apache License 2.0
7 stars 2 forks source link

Fixing packaging issue preventing dependencies from being uploaded too #2

Closed jfalkenstein closed 2 years ago

jfalkenstein commented 2 years ago

I discovered an issue where the compiled dependencies from layers and functions are not actually being uploaded.

The cause of this is because the handler is directing sam package to use the pre-build template (located at the template handler's "path" argument) rather than the post-build template (which will be in the pre-build template's .aws-sam directory). We don't actually need to specify the template path anyway, since it's only in special circumstances that this would ever be needed; sam package uses the right directory and template by default.

jfalkenstein commented 2 years ago

@zaro0508 @zxiiro Could I get a review on this? It's a pretty small change and this handler is effectively broken until this gets merged. It looks like I have permissions to merge this without review... but I'm guessing that's discouraged (rightly so).