[Resolve #1503] Dependency conflict with packaging

alex-harvey-z3q commented 3 months ago

This restores the flexible constraints on packaging, allowing >=16.8 for compatibility with many old tools in the Sceptre ecosystem.

For example: https://github.com/Sceptre/sceptre-aws-stackoutput-resolver/blob/master/requirements.txt#L6

PR Checklist

[x] Wrote a good commit message & description [see guide below].
[x] Commit message starts with [Resolve #issue-number].
[ ] Added/Updated unit tests.
[ ] Added/Updated integration tests (if applicable).
[x] All unit tests (poetry run tox) are passing.
[x] Used the same coding conventions as the rest of the project.
[x] The new code passes pre-commit validations (poetry run pre-commit run --all-files).
[x] The PR relates to only one subject with a clear title. and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

[ ] Before merge squash related commits.

Other Information

Guide to writing a good commit

zaro0508 commented 3 months ago

this reverts PR #1495 which was intended to address issue #1478. Even with this revert, what if an install of sceptre happens to install packaging version >16.8 ? wouldn't that still break downstream dependencies? I have a feeling that the right thing to do here is to move forward.

alex-harvey-z3q commented 3 months ago

this reverts PR #1495 which was intended to address issue #1478.

It doesn't revert PR #1495, it restores the original version that I did of PR #1495. I believe the right thing to do here is merge this PR as soon as possible, otherwise latest Sceptre is broken for everyone in the world who tries to install any of our plugins along side of Sceptre. The other option would be to find and re-release every single plugin that has the 16.8 packaging dependency. That would take some time.

Sceptre / sceptre