Open alex-harvey-z3q opened 1 month ago
I think handling in connection manager seems like the right place therefore i think i prefer this over PR #1522. However instead of using this approach how about we switch to a cleaner approach using aws-error-utils which i found here https://stackoverflow.com/a/33663484
I am not sure I like that idea, as it introduces a dependency on a third party project and, by the looks of it, has not been committed to in over a year https://github.com/benkehoe/aws-error-utils
I agree with you that handling all of these exceptions is going to lead to some bloat and we may eventually need another helper method but I think we'll figure it out and keep the code clean?
What do you think @dboitnot ?
Proof of concept for centralised exception handling.
See also https://github.com/Sceptre/sceptre/pull/1522
PR Checklist
[Resolve #issue-number]
.poetry run tox
) are passing.poetry run pre-commit run --all-files
).Approver/Reviewer Checklist
Other Information
Guide to writing a good commit