Sceptre / sceptre

Build better AWS infrastructure
https://docs.sceptre-project.org
Other
1.48k stars 313 forks source link

[Resolve #1519] PoC for centralised exception handling #1525

Open alex-harvey-z3q opened 3 weeks ago

alex-harvey-z3q commented 3 weeks ago

Proof of concept for centralised exception handling.

See also https://github.com/Sceptre/sceptre/pull/1522

PR Checklist

Approver/Reviewer Checklist

Other Information

Guide to writing a good commit

alex-harvey-z3q commented 3 weeks ago

I think handling in connection manager seems like the right place therefore i think i prefer this over PR #1522. However instead of using this approach how about we switch to a cleaner approach using aws-error-utils which i found here https://stackoverflow.com/a/33663484

I am not sure I like that idea, as it introduces a dependency on a third party project and, by the looks of it, has not been committed to in over a year https://github.com/benkehoe/aws-error-utils

I agree with you that handling all of these exceptions is going to lead to some bloat and we may eventually need another helper method but I think we'll figure it out and keep the code clean?

alex-harvey-z3q commented 3 weeks ago

What do you think @dboitnot ?