Sceptre / sceptre

Build better AWS infrastructure
https://docs.sceptre-project.org
Other
1.49k stars 313 forks source link

No hooks for update-stack-cs #277

Closed connorwilliamscr closed 6 years ago

connorwilliamscr commented 6 years ago

For SAM stacks, you can only update with update-stack-cs, but there are no hooks that yet exist for this command. This would be super useful for writing a custom hook for running the aws cloudformation package command which needs to be run every time the Lambda code is updated and needs to be re-deployed.

If you try to use update-stack, the following error occurs: An error occurred (ValidationError) when calling the UpdateStack operation: UpdateStack cannot be used with templates containing Transforms.

connorwilliamscr commented 6 years ago

Closed because I thought I saw a pull request that solved this but I was wrong 👎

theseanything commented 6 years ago

Ultimately we need to just implement SAM support - see relevant ticket #324.

mithun commented 6 years ago

@theseanything actually, we would like to see this feature independent of SAM support. We heavily use update-stack-cs instead of update-stack and would like to have hooks triggered when using change-sets.

ianburrell commented 6 years ago

Should be possible to add hook to the update_with_change_set process. "create_change_set" would probably be the best place, but would be a little confusing.