search

SchabanBo / qlevar_router

Manage you project Routes. Create nested routes. Simply navigation without context to your pages. Change only one sub widget in your page when navigating to new route.
MIT License
86 stars 22 forks source link

Fix replaceLastName Bug #122

Closed devhammed closed 1 year ago

devhammed commented 1 year ago

This PR fixed a bug in the replaceLastName() function /lib/src/controllers/qrouter_controller.dart that is using the current route params as the params for the next route which is causing an error because the findName() function will be using the wrong params to search for matching route.

fixes #78

codecov[bot] commented 1 year ago

Codecov Report

Merging #122 (fc7c638) into master (8ef42a1) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   90.51%   90.53%   +0.01%     
==========================================
  Files          25       25              
  Lines        1107     1109       +2     
==========================================
+ Hits         1002     1004       +2     
  Misses        105      105
Impacted Files Coverage Δ
lib/src/controllers/qrouter_controller.dart 84.04% <100.00%> (+0.17%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SchabanBo commented 1 year ago

LGTM, thanks.

devhammed commented 1 year ago

@SchabanBo When will a new version be released?

I currently had to use my own locally modified version.

SchabanBo commented 1 year ago

@devhammed I will try to make it this week

SchabanBo commented 1 year ago

@devhammed The new version is live