search

SchabanBo / qlevar_router

Manage you project Routes. Create nested routes. Simply navigation without context to your pages. Change only one sub widget in your page when navigating to new route.
MIT License
87 stars 22 forks source link

Path '/' not working with QRoute.withChild, when using QR.toName #129

Closed k-ane closed 1 year ago

k-ane commented 1 year ago

This is a follow up to this issue: https://github.com/SchabanBo/qlevar_router/issues/111

When navigating using the QR.to(path) syntax, everything works as expected. However when using names instead of paths (QR.toName), the routing breaks.

You can verify this by changing the provided test to use QR.toName instead of QR.to: https://github.com/SchabanBo/qlevar_router/blob/develop/test/scenario-code/issue_111_test.dart

electraport commented 1 year ago

Can confirm these fixes are good, have now moved to the repo by path that has them in it. I've been thinking for almost a year this was me not understanding how the router worked :) Cost me months but this now works exactly as I expected. @SchabanBo please merge ASAP so we don't have to use this fork. Thanks!

SchabanBo commented 1 year ago

@k-ane can you open PR?