search

SchapplM / xbmc-addon-service-watchedlist

Addon for Kodi Media Center to organize "watched"-status of media.
http://kodi.wiki/view/Add-on:WatchedList
GNU General Public License v3.0
32 stars 13 forks source link

Fix reference to sometimes not available IMDB number #53

Closed SchapplM closed 2 years ago

SchapplM commented 2 years ago

As reported in the forum, the switch to TMDB as default scraper lead to many media in the library not having an IMDB id. The WL addon only uses the IMDB id for historic reasons (was the only ID when development started). One possible solution would be to restructure the WL database to incorporate different scraper IDs (e.g. also TMDB). A faster workaround would be to use the IMDB mechanism of the addon "Light IMDb Ratings Update".

Nionor commented 2 years ago

Yup that addon only looks it up through the tmdb api, so you can ask for external id and get imdb id (and others) back. e.g {"id":451048,"imdb_id":"tt0870154","facebook_id":"JungleCruise","instagram_id":"disneysjunglecruise","twitter_id":"JungleCruise"}

Nionor commented 2 years ago

I had a quick look around today and saw there is a uniqueid in the kodi-db and if you query for it you get both imdb and tmdb values, from what I can see even if you haven't scraped with the imdb scraper. So I tried to just add the uniqueid to the rpc call and change the item['imdbnumber'] to item['uniqueid']['imdb'] and it read in all my watched movies fine after that.

The WL db came from a LibreELEC 9.2.8 and was imported to Kodi 19.2 and before I got the "has no imdb-number or themoviedb-number in database" error for all movies.

SchapplM commented 2 years ago

Thanks for looking into this. Can you provide a pull request? Then I can test directly and merge to the official addon repo.

Nionor commented 2 years ago

Done, but as I wrote in the pull I haven't tested this much at all.

SchapplM commented 2 years ago

Done.