Schauweg / Smooth-Swapping

A Minecraft Fabric mod which moves items smoothly in inventories.
Other
31 stars 14 forks source link

incompatibility with Rechiseled #97

Open peow opened 2 months ago

peow commented 2 months ago

Rechiseled adds the Chisel, with which you can exchange decorative blocks, however the GUI added by the mod doesn't work well with Smooth Swapping, when you press Shift+Click to take the block to your inventory, the game crashes

2024-05-13_19 01 47

interestingly, it doesn't crash when you press Shift+Click from your inventory to the Chisel GUI, but the animation doesn't happen

mod link: https://modrinth.com/mod/rechiseled

I'm using Smooth Swapping 0.9.3.1 and Rechiseled 1.1.6, on Fabric 1.20.1


I believe that there are other mod GUIs that also don't work correctly with Smooth Swapping, so I think it would be interesting if your mod had a way to block specific GUIs from having the animation added by your mod

for example the “Flow” mod which adds Ease In and Ease Out when opening and closing a GUI, is also incompatible with the Rechiseled mod, however Flow has a compatibility tab where you can put the ScreenClassName of a GUI and then it is added to the blacklist

Here's what it looks like:

2024-05-13_19 08 12

in this case, Rechiseled's ScreenClassName is “com.supermartijn642.core.gui.WidgetContainerScreen”

whenever Smooth Swapping crashes, the crashlog tells you the name of the screen, so the user can add it to the list of disabled screens

the Flow mod has the ARR license, but the source code is open so you could see how the blacklist function was implemented to get an idea, or you could talk to the mod developer asking for permission to use the code

I believe this is where you'll find the part about disabling screens: https://github.com/IMB11/Flow/blob/118b7c59127cbd5b8476e7c26a5e10cdc929b15f/src/main/java/dev/imb11/flow/mixin/ScreenMixin.java#L91


if is possible to fix this issue i ask you to make a update to Fabric 1.20.1, thanks for reading