search

ScheiklP / sofa_env

Reinforcement learning environments for robot-assisted laparoscopic surgery
MIT License
47 stars 14 forks source link

Add files via upload #5

Closed sulton1995 closed 1 year ago

sulton1995 commented 1 year ago

the task is done. Can you please check it?

ScheiklP commented 1 year ago

Hi @sulton1995 have you checked that the code actually runs? For example by running the tests in the test folder, or running python3 sofa_env/scenes/controllable_object_example/controllable_env.py

ScheiklP commented 1 year ago

Hi @sulton1995, I am sorry but I cannot review the code like this.

You do not initialize a pygame window, so trying to read from it in the function will not work.

Also

    def get_rgb(self,render_fr):
        if render_fr == Framework.PYGLET:
            return self.get_rgb_from_pygame()
        elif render_fr == Framework.PYGAME:
            return self.get_rgb_from_pygame()

calls the same function.

I will close the PR. Feel free to properly test your implementation and open a new PR at a later time.