search

ScheiklP / sofa_env

Reinforcement learning environments for robot-assisted laparoscopic surgery
MIT License
53 stars 15 forks source link

New framwork pygame implementation #6

Closed badhon1512 closed 1 year ago

badhon1512 commented 1 year ago

Here, I have added a new framework pygame.

ScheiklP commented 1 year ago

Hi @badhon1512, thanks for the PR! I have made some changes and pushed them to a branch of the same name in this repo.

Could you merge these changes into your branch to update the PR?

There are two further TODOs:

  1. RenderMode.HEADLESS is currently not working for RenderFramework.PYGAME
  2. Could you implement the get_depth_from_pygame function? It is added with a NotImplemented tag in the new branch.

Cheers, Paul

badhon1512 commented 1 year ago

Hi @ScheiklP,

Thank you for your message and for reviewing the pull request. I have received your changes and have started working on them. I have taken note of the two additional tasks you mentioned.

Thank you for bringing these tasks to my attention. I will address them promptly and update the pull request accordingly.

Best regards, Badhon

badhon1512 commented 1 year ago

Hi @ScheiklP , I have completed the previous tasks assigned to me(2 to-do tasks), and after testing, everything appears to be functioning correctly. I would appreciate it if you could review my code and provide any feedback or suggestions you may have.

Best regards, Badhon

ScheiklP commented 1 year ago

Hi @badhon1512, I have made some final changes and pushed them to a branch of the same name in this repo. Could you merge these changes into your branch to update the PR?

Cheers, Paul

badhon1512 commented 1 year ago

Hi @ScheiklP , I have merged your branch into mine, and the pull request has been updated.

Cheers, Badhon