search

Scheirle / pelican_comment_system

Allows you to add static comments to your articles on your Pelican blog.
Other
6 stars 1 forks source link

Add 'default_status' and 'allowed_statuses' #7

Closed trevorld closed 4 years ago

trevorld commented 5 years ago

Or you could wait to see if 'pelican' fixes their default status code. Without a fix here or there this plugin won't work.

https://github.com/getpelican/pelican/issues/2558

MinchinWeb commented 4 years ago

Would love to see this merged :)

justinmayer commented 4 years ago

@MinchinWeb: If you want, you could submit a PR to address the issue upstream in Pelican itself, as I noted in a comment last month.

MinchinWeb commented 4 years ago

@justinmayer : Pull Request (pelican#2609) has been created! Also, I cleaned up a few failing-on-Windows tests (pelican#2609). As well, I have two languishing pull requests: pelican#2431 that standardizes how paths in settings are built, and pelican#2428 that adds Windows testing to Travis-CI; can you let me know what's needed to move these last two along? Thanks!

@Scheirle : Even with these pull requests submitted to Pelican, I think it would still be worthwhile to merge this one too.

justinmayer commented 4 years ago

Thanks to @MinchinWeb, the fix for this issue has been merged upstream and has been automatically published as Pelican 4.1.1, courtesy of AutoPub. ✨